Skip to content

Update blueprint doc for remote model batch semantic highlighting #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2025
Merged

Update blueprint doc for remote model batch semantic highlighting #4309

merged 2 commits into from
Oct 21, 2025
+74 −4

Conversation

junqiu-lei
Copy link
Member

Description

Update blueprint doc for remote model batch semantic highlighting

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei
Update blueprint doc for remote model batch semantic highlighting
d22c211 
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 13, 2025 21:02 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 13, 2025 21:02 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 13, 2025 21:02 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 13, 2025 21:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.14%. Comparing base (709ba4b) to head (d22c211).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4309   +/-   ##
=========================================
  Coverage     80.14%   80.14%           
  Complexity    10175    10175           
=========================================
  Files           854      854           
  Lines         44231    44231           
  Branches       5117     5117           
=========================================
  Hits          35450    35450           
  Misses         6631     6631           
  Partials       2150     2150
Flag Coverage Δ
ml-commons 80.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 20, 2025 23:54 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval October 20, 2025 23:54 — with GitHub Actions Inactive
@mingshl mingshl had a problem deploying to ml-commons-cicd-env-require-approval October 21, 2025 17:33 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env-require-approval October 21, 2025 17:33 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env-require-approval October 21, 2025 17:33 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env-require-approval October 21, 2025 17:33 — with GitHub Actions Failure
@junqiu-lei
Copy link
Member Author

This PR only changes in document, the test failure isn't related to the PR code change.

@junqiu-lei
Copy link
Member Author

This PR only changes in document, the test failure isn't related to the PR code change.

Currently ml-commons maintainers not able to merge the PR due to recently merge policy update with CI check at #4152

In long term we could add path to exclusive the required CI pass like document changes, e.g. https://github.com/opensearch-project/k-NN/blob/main/.github/workflows/CI.yml#L18-L30

Similar case from opensearch-project/k-NN#2952, requesting admin maintainer @peterzhuamazon to merge the PR. Thanks!

cc: @mingshl @b4sjoo @nathaliellenaa

@peterzhuamazon
Copy link
Member

Since the changed file is only related to `docs:

docs/remote_inference_blueprints/standard_blueprints/sagemaker_semantic_highlighter_standard_blueprint.md

Based on request of @junqiu-lei and approval by @b4sjoo @mingshl I will merge this PR. Thanks.

@peterzhuamazon peterzhuamazon merged commit 66bcde7 into opensearch-project:main Oct 21, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@mingshl mingshl mingshl approved these changes

@b4sjoo b4sjoo b4sjoo approved these changes

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman sam-herman is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@pyek-bot pyek-bot Awaiting requested review from pyek-bot pyek-bot is a code owner

+1 more reviewer

@nathaliellenaa nathaliellenaa nathaliellenaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@junqiu-lei @peterzhuamazon @mingshl @b4sjoo @nathaliellenaa